[MPlayer-dev-eng] [PATCH] build: Keep compiler-specific warning flags for debug and profiling builds

[Alexander Strasser]

On 2013-07-17 00:45 +0200, Alexander Strasser wrote:
> On 2013-07-16 17:32 +0200, Diego Biurrun wrote:
> > On 2013-07-15 00:34, Alexander Strasser wrote:
> > >Without warning flags like -Werror-implicit-function-declaration
> > >some tests like gethostname2 will compile and therefore succeed.
> > >But not without causing strange run-time failures later on e.g.
> > >when compiled for x86_64 .
> > >
> > >Having useful warning flags dropped on debug enabled builds seems
> > >also counter intuitive to me.
> > >
> > >This does not necessarily help with all compilers, but that can
> > >be fixed if those compilers have the necessary switches to be
> > >more strict.
> > >
[patch snipped]
> > 
> > This is far from fixing the root cause, which is that compiler flags
> > handling in configure is a royal mess, but it doesn't make things
> > worse for the more common gcc case.  This won't work for some or all
> > of suncc, icc, clang, but they look just as broken before.
> 
>   I agree that flags handling is suboptimal; to say it in a nice way.
> 
> > Commit if you feel like it ...
> 
>   Will commit in a few days. I don't like to keep such a trap around.

  Committed.

Thanks for having a look at the patch,
  Alexander