[MPlayer-dev-eng] [PATCH 2/3] Fix some warnings with Objective-C code and declarations
Xidorn Quan
quanxunzhen at gmail.com
Tue Jul 16 03:47:28 CEST 2013
Hi Alexander,
On Tue, Jul 16, 2013 at 3:13 AM, Alexander Strasser <eclipse7 at gmx.net>wrote:
> Hi Xidorn,
>
> IIRC you are on OSX and you can commit to the MPlayer repository.
>
> So it should be fine for you to apply this if you think it is correct.
> Do not forget the attribution to the author, it can happen easily.
>
OK, I committed.
Maybe splitting the patch into rename method and include part
> would be better as well as is including the compiler warning in
> the body of the commit message.
>
I removed the include part since I saw no difference in the output of
compiler.
--
Xidorn Quan
GnuPG fingerprint: 6F1E DF9A D250 7505 63E2 345E 7570 8D3F 7C9A 1209
More information about the MPlayer-dev-eng
mailing list