[MPlayer-dev-eng] [PATCH 2/3] Fix some warnings with Objective-C code and declarations

Jiang Jiang gzjjgod at gmail.com
Mon Jul 15 21:56:35 CEST 2013


On Mon, Jul 15, 2013 at 9:13 PM, Alexander Strasser <eclipse7 at gmx.net> wrote:
>   I just forgot because I cut out the patch from the email, but would
> configureSize be a better name than configWidth?

The full Obj-C method name here is actually:

-configWidth:height:flags:

So "Width" only describes the first argument.

If changing to -configSize: then something like:

-configSize:(NSSize)size flags:(uint32_t)flags

should be more appropriate.

- Jiang


More information about the MPlayer-dev-eng mailing list