[MPlayer-dev-eng] [PATCH] Fix compilation error in libmpdemux/demux_gif.c

[Nicolas Coiffier]

Hi Alexander,

The version of GIFLIB is the build-in version of my archlinux distribution,
giflib-4.2.1-3, without any additional modifications.

Here are some informations about my build tools (if it may be relevant) :

pacman -Qi giflib
Name           : giflib
Version        : 4.2.1-3
Description    : A library for reading and writing gif images
Architecture   : x86_64
URL            : http://sourceforge.net/projects/giflib/
Licenses       : MIT
Groups         : None
Provides       : libungif=4.2.1
Depends On     : libx11
Optional Deps  : None
Required By    : imlib2
Optional For   : jre7-openjdk
Conflicts With : libungif
Replaces       : libungif
Installed Size : 530.00 KiB
Packager       : Bartłomiej Piotrowski <b at bpiotrowski.pl>
Build Date     : Mon 01 Jul 2013 09:06:44 PM CEST
Install Date   : Wed 10 Jul 2013 02:47:07 AM CEST
Install Reason : Installed as a dependency for another package
Install Script : No
Validated By   : Signature


ls -l /lib/libc[.-]*
-rwxr-xr-x 1 root root 2035252 May 30 08:34 /lib/libc-2.17.so
-rw-r--r-- 1 root root 4860310 May 30 08:34 /lib/libc.a
-rw-r--r-- 1 root root     255 May 30 08:33 /lib/libc.so
lrwxrwxrwx 1 root root      12 May 30 08:34 /lib/libc.so.6 -> libc-2.17.so

gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/4.8.1/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /build/gcc/src/gcc-4.8.1/configure --prefix=/usr
--libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man
--infodir=/usr/share/info
--with-bugurl=https://bugs.archlinux.org/--enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++
--enable-shared
--enable-threads=posix --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch
--enable-gnu-unique-object --enable-linker-build-id
--enable-cloog-backend=isl --disable-cloog-version-check --enable-lto
--enable-gold --enable-ld=default --enable-plugin --with-plugin-ld=ld.gold
--with-linker-hash-style=gnu --disable-install-libiberty --disable-multilib
--disable-libssp --disable-werror --enable-checking=release
Thread model: posix
gcc version 4.8.1 (GCC)

ld -v
GNU ld (GNU Binutils) 2.23.2

Should I report this issue in the bug tracker instead ?

Nicolas


> ---------- Message transféré ----------
> From: Alexander Strasser <eclipse7 at gmx.net>
> To: mplayer-dev-eng at mplayerhq.hu
> Cc:
> Date: Sun, 14 Jul 2013 02:27:27 +0200
> Subject: Re: [MPlayer-dev-eng] [PATCH] Fix compilation error in
> libmpdemux/demux_gif.c
> Hi,
>
>   thank you for reporting the problem and forwarding the patch,
> but please read on below...
>
> On 2013-07-13 17:55 +0200, Nicolas Coiffier wrote:
> > When I tried to compile mplayer, I got the following errors:
> >
> > libmpdemux/demux_gif.c: In function 'demux_gif_fill_buffer':
> > libmpdemux/demux_gif.c:97:7: error: implicit declaration of function
> > 'PrintGifError' [-Werror=implicit-function-declaration]
> >        PrintGifError();
> >        ^
> > cc1: some warnings being treated as errors
> > make: *** [libmpdemux/demux_gif.o] Error 1
> >
> > A little googling give me the following link:
> > https://bugs.archlinux.org/task/36039
> >
> > I applied it on svn revision 36356, and it worked fine for me. So I
> > transfer this patch to the appropriate mplayer mailing-list.
>
>   I wonder what is really going on though. I see a change from
> about a year ago that would cause problems with the cited function.
> But it would need a different approach to fix it, at least according
> to my quick analysis.
>
>   Can you find out and tell me what exact version of GIFLIB you are
> trying to build against?
>
>
>   Alexander
>
>