[MPlayer-dev-eng] [PATCH] change aspect ratio in gtk gui

[Ingo Brückl]

Reimar Döffinger wrote on Thu, 11 Jul 2013 20:07:32 +0200:

> On 11.07.2013, at 17:34, wm4 <nfxjfg at googlemail.com> wrote:
>> On Thu, 11 Jul 2013 16:48:44 +0200
>> Ingo Brückl <ib at wupperonline.de> wrote:
>>
>>> Actually, the GUI "chooses" nothing, it's returned from
>>> vo_find_depth_from_visuals() and its ID is 0x21, not 0x11f.
>>> Still different to the glx choice (but of same depth).
>>
>> You could probably solve this by always creating a window in the VO,
>> even with -wid/GUI in use.

> Is there anything to solve actually?
> I don't really know if there is a point to the failing function.
> Also, just taking the visual of the window as-is would be an option, so
> I don't think there is a lack of options, more if it makes sense to do
> anything about it.

I'm not sure I understand you, but what about this patch (consisting of two
parts and a later indentation of the else branch) that stops X11 from raising
an error?

Part 1: Add missing XFree() - necessary for glXChooseVisual() as well.
Part 2: Add if/else for WinID.

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gl_common.c.diff
Type: text/x-diff
Size: 1003 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130712/c00e48bc/attachment.bin>