[MPlayer-dev-eng] [PATCH] change aspect ratio in gtk gui

[Ingo Brückl]

Reimar Döffinger wrote on Thu, 11 Jul 2013 08:58:12 +0200:

> Actually I am certain it is a driver bug, it's just possible we do
> something strange/wrong, too. (Though the fact that it works fine with all
> others, including embedded OpenGL ES drivers makes it less likely).

Except for the X11 error, I don't have any problems with -vo gl (although I
know that there isn't much of gl support with my old hardware).

The X11 error

  [ws]  Error code: 8 - BadMatch (invalid parameter attributes)

I get seems to be with XChangeWindowAttributes() at line 1112 in
libvo/x11_common.c. Since it occurs with a XSetWindowColormap() call instead
as well, the man page indicates that the colormap

  XCreateColormap(mDisplay, mRootWin, vinfo->visual, AllocNone)

at line 2770 in libvo/gl_common.c might not have the same visual type as the
window

  vo_window = WinID ? (Window)WinID : mRootWin

at line 1107 in libvo/x11_common.c.

An indeed:

  [ws] display name: :0.0 => local display.
  vo: X11 truecolor visual 0x21, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x23, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x24, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x25, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x26, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x27, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x28, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x29, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x2a, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x2b, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x2c, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x2d, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x2e, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x2f, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x30, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x31, depth 24, R:FF0000 G:FF00 B:FF
  vo: X11 truecolor visual 0x11f, depth 32, R:FF0000 G:FF00 B:FF
  [ws] Screen depth: 32

the GUI chooses visual ID 0x11f, but the gl driver does not:

  [gl] GLX chose visual with ID 0x2e

So, even though it's got nothing to do with Stephen's crash, is there a
problem with the gl vo choosing a wrong visual? And if so, how do we fix it?

Ingo