[MPlayer-dev-eng] [FFmpeg-devel] [PATCH] FFmpeg: libavfilter/libmpcodecs: add vf_stereo3d high quality green-magenta and yellow-blue dubois anaglyph 3D output support

[Reimar Döffinger]

Hello,
Thanks for the patch, just one minor comment for the future:

On Thu, Jan 31, 2013 at 12:52:22PM +0100, thomas schorpp wrote:
> -        case ANAGLYPH_YB_COLOR: {
> +        case ANAGLYPH_YB_COLOR:
> +        case ANAGLYPH_YB_DUBOIS: {

This part is really a bugfix, whereas the rest is a new feature.
You should try to always split these into separate patches.
This has several advantages, among them making it easier for
people to notice that something was fixed and they maybe should
try again if they noticed it not working before, and also
would make it easier to maintain a stable version that only
gets bugfixes but no new features - in case someone ever wants
to do that.

Just repeating to be clear: nothing to do for you for this patch since it's
already committed, just in case you should have more patches
somewhen.

Thanks,
Reimar