[MPlayer-dev-eng] [PATCH] configure: check for gsm.h and openjpeg-1.5/openjpeg.h

[Alexander Strasser]

Hi Hans-Dieter, hi Erik,

Erik Auerswald wrote:
> On 01/26/2013 09:35 PM, Hans-Dieter Kosch wrote:
> >Alexander Strasser wrote:
> >>Well something like that would definitely be practical for now. On
> >>the flip side it can hide some coding mistakes. E.g. if some #defines
> >>get removed.
> >
> >Warnings sometimes pointed me to mistakes, which otherwise would have
> >taken much effort to debug. I'd not artificially suppress them.
> 
> That is the idea of compiler warnings, and I too think that it is
> worthwhile to write warning free code, because in the end the code
> is less buggy. We are in the minority here, and we are not MPlayer
> developers, though.

  please keep the discussion focused on this specific switch. It is
really not helpful to discuss compiler warnings in general here. Actually
we should have made a new thread or changed the subject line a few mails
ago.

> >However, if all warnings are let be, serious ones could be hardly evident.
> >
> >So, I think it's best to fix warnings at the source.
> 
> Sadly, the MPlayer developers prefer to not fix warnings. Not even
> those they explicitly enable. They don't even accept fixes for those
> warnings.

  Though not to be discussed here. I do not think this is the opinion
of the "MPlayer developers". Point in case: I committed a patch that
reduced warnings, from you Erik. If my memory serves me right I even
encouraged you to go on with eliminating warnings, which I am happy
you do.

> As such it is sensible to disable or rather not explicitly enable
> the warnings not intended to be fixed.

  The warnings in question are intended to be fixed. It is mostly a
problem of leveraging the build system of FFmpeg. I even wrote in
part of my original reply that the warning should be reactivated when
we have that in place.

> :-(

  We can for sure open a new discussion about warnings and how to
deal with them. For my taste we have way too many of them currently.
I also would appreciate less noisy output from the build system like
was suggested by Ingo. So warnings can be differentiated from build
commands more easily.

  Alexander