[MPlayer-dev-eng] [PATCH] configure: check for gsm.h and openjpeg-1.5/openjpeg.h

[Alexander Strasser]

Hi Erik,

Erik Auerswald wrote:
> On 01/26/2013 03:13 AM, Alexander Strasser wrote:
> >Josh wrote:
> >>On 1/25/2013 19:37, Diego Biurrun wrote:
> >>>
> >>>I must say this whole business of duplicating ./ffmpeg/configure in
> >>>./configure is getting crazier by the day.  ./configure is approaching
> >>>10k lines of brittle, hard-to-maintain shell scripting with dizzying
> >>>amounts of code duplication.
> >>>
> >>>Almost all of the changes done to configure are part of this cat and
> >>>mouse game.  Somebody needs to step up and fix this properly instead.
> >
> >   I have to say I agree with Diego on this one!
> 
> +1
> 
> >>Just let it be until compiling breaks and actually needs fixing. I
> >>have GSM in my mplayer build and despite the wundef playing gsm
> >>encoded files through libgsm or ffgsm seems to work perfectly fine.
> >
> >   IMHO the patches can be committed if they are correct and done
> >anyway. It doesn't do much harm anymore and will all go away once
> >we have a better solution to deal with FFmpeg configuration.
> 
> IMHO all those warnings can be easily fixed in an obviously correct
> way. If you guys don't care about the warnings, just remove -Wundef
> from CFLAGS, as with this untested and probably white-space damaged
> patch:

  Well something like that would definitely be practical for now. On
the flip side it can hide some coding mistakes. E.g. if some #defines
get removed. I wouldn't value it to strong right now, but the change
should be reverted once our build system is more capable.

  So what is the opinion of other developers? Please speak up.


  Alexander

> Index: configure
> ===================================================================
> --- configure   (revision 35898)
> +++ configure   (working copy)
> @@ -2670,7 +2670,6 @@
> 
>  if test "$cc_vendor" = "gnu" ; then
>    cflag_check -fno-tree-vectorize && CFLAGS="$CFLAGS -fno-tree-vectorize"
> -  cflag_check -Wundef && WARNFLAGS="-Wundef $WARNFLAGS"
>    cflag_check -std=gnu99 && WARN_CFLAGS="-std=gnu99 $WARN_CFLAGS"
>    cflag_check -Wdeclaration-after-statement &&
> WARN_CFLAGS="-Wdeclaration-after-statement $WARN_CFLAGS"
>    cflag_check -Wno-pointer-sign && WARN_CFLAGS="-Wno-pointer-sign
> $WARN_CFLAGS"