[MPlayer-dev-eng] [PATCH] Fix libdvdcss on OS/2

Erik Auerswald auerswal at unix-ag.uni-kl.de
Tue Jan 22 11:13:27 CET 2013


Hi,

On Mon, Jan 21, 2013 at 11:47:56PM -0800, Dave Yeo wrote:
> r35807 seems to have broke compilation on OS/2 due to OS/2 having  
> direct.h and it being unconditionally checked for.
> One possible fix,
>
> Index: libdvdcss.c
> ===================================================================
> --- libdvdcss.c (revision 35820)
> +++ libdvdcss.c (working copy)
> @@ -238,7 +238,7 @@
>       */
>      if( psz_cache == NULL || psz_cache[0] == '\0' )
>      {
> -#if HAVE_DIRECT_H
> +#if defined (HAVE_DIRECT_H) && defined (HAVE_WIN_H)

I'd suggest #if HAVE_DIRECT_H && HAVE_WIN_H (not tested), since those
#defines are supposed to be always available, with value 1 if the feature
is detected, 0 otherwise.

Erik
-- 
It's hard to avoid programming overcomplicated monoliths if none of your
programs can talk to each other.
                        -- Eric S. Raymond


More information about the MPlayer-dev-eng mailing list