[MPlayer-dev-eng] [PATCH] Check for windows.h

Diego Biurrun diego at biurrun.de
Tue Jan 22 00:30:48 CET 2013


On Tue, Jan 08, 2013 at 06:49:57PM +0100, Erik Auerswald wrote:
> On 01/08/2013 06:01 PM, Josh Finch wrote:
> >Checking for the headers doesnt have to be in the "if mingw32" statement, just end the if statement after checking for w32threads.
> 
> The attached patch does just this. Thus it fixes the following
> -Wundef warnings on non-Windows systems:
> 
> libdvdcss/libdvdcss.c:123:5: warning: "HAVE_DIRECT_H" is not defined
> [-Wundef]
> libdvdcss/libdvdcss.c:241:5: warning: "HAVE_DIRECT_H" is not defined
> [-Wundef]
> libavformat/cache.c:36:5: warning: "HAVE_IO_H" is not defined [-Wundef]
> libavformat/file.c:26:5: warning: "HAVE_IO_H" is not defined [-Wundef]
> libavutil/file.c:28:5: warning: "HAVE_IO_H" is not defined [-Wundef]
> libavutil/log.c:32:5: warning: "HAVE_IO_H" is not defined [-Wundef]
> libavutil/time.c:32:5: warning: "HAVE_WINDOWS_H" is not defined [-Wundef]
> 
> On Windows systems, windows.h will be included in
> ffmpeg/libavutil/time.c if it is detected.
> 
> This patch replaces both other patches sent by me today.

Applied a slightly different version, thanks.

> After applying this change, the OS/2 thread checks should be moved
> up above the direct.h, io.h and windows.h checks to improve
> maintainability.

Yes, will do in a moment.

Diego


More information about the MPlayer-dev-eng mailing list