[MPlayer-dev-eng] [PATCH] Check for windows.h

Erik Auerswald auerswal at unix-ag.uni-kl.de
Tue Jan 8 17:45:51 CET 2013


Hi Josh,

On 01/08/2013 05:30 PM, Josh wrote:
> On 1/8/2013 06:55, Erik Auerswald wrote:
>> def_windows_h='#define HAVE_WINDOWS_H 0'
>
> The follow would fall more in line with the rest of the configure script.
> [...patch keeping the check inside if win32...]

But that would not fix the warning for non-Windows systems.

libavutil/time.c:32:5: warning: "HAVE_WINDOWS_H" is not defined [-Wundef]

The one file using the define checks unconditionally #if HAVE_WINDOWS_H 
and as such I very much prefer to always have this define.

The method used in my patch is used for thread support checking already 
(define every variable to 0, let Windows and OS/2 check change the value 
from 0 to 1 if applicable). Just look a bit further up in the file. ;-)

Thanks,
Erik


More information about the MPlayer-dev-eng mailing list