[MPlayer-dev-eng] [PATCH] af_volnorm: make it work with float audio data
mywing81 at gmail.com
Thu Feb 28 12:19:53 CET 2013
2012/12/16 Giorgio Vazzana <mywing81 at gmail.com>:
> 2012/12/15 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
>> On 15 Dec 2012, at 15:04, Giorgio Vazzana <mywing81 at gmail.com> wrote:
>>> The attached patch fixes this, assuming float samples are in the range
>>> [-1.0f, 1.0f] (is there any codec that uses a different range?)
>>> I have used it locally for about a month now, so I thought I'd send it upstream.
>> Thanks, I think the multiplication with 1.0 is just confusing, I'd just remove it completely.
>> Otherwise it seems right.
> Ok, new patch attached.
>>> * method*_int16 could use a lrintf() in the scale loop
>> Hm, I forgot if it's really lrintf, but some of those float -> int conversion functions are awfully slow in some cases.
> It's up to you, I saw it was already used in af_format::float2int().
> Giorgio Vazzana
More information about the MPlayer-dev-eng