[MPlayer-dev-eng] [PATCH] configure: much faster configure --help
diego at biurrun.de
Mon Feb 18 11:54:47 CET 2013
On Sat, Feb 16, 2013 at 10:02:05PM +0100, Alexander Strasser wrote:
> Diego Biurrun wrote:
> > On Fri, Feb 15, 2013 at 03:39:01AM +0100, Diego Biurrun wrote:
> > > On Wed, Feb 13, 2013 at 05:47:25PM +0100, Alexander Strasser wrote:
> > > > Diego Biurrun wrote:
> > > > > On Mon, Feb 11, 2013 at 05:40:53PM +0100, Erik Auerswald wrote:
> > > > > > This drastically speeds up checking for available configure options,
> > > > > > if done the common way of "./configure --help". If the --help resp.
> > > > > > -h option is somewhere else on configure's command line, the (kept)
> > > > > > existing check will find this after doing all the initial setup
> > > > > > work, taking much longer overall.
> > > > >
> > > > > I'm not really convinced of the usefulness of this in the first place,
> > > > > but even then I consider it overkill. Just check for --help/-h early.
> > > >
> > > > I do not understand your reasoning.
> > > >
> > > > The latest version Erik and I worked out:
> > > >
> > > > 1. Detects the help option in every position
> > > > 2. Is consistent with current configure behaviour
> > > > 3. Does not duplicate the check for the help option
> > >
> > > Maybe, maybe not. The only version I saw moved around a large swath
> > > of code and might have unforeseen side-effects.
> > Note that I have cooked up a solution of my own, some of the preliminaries
> > are still buggy though.
> I had the attached patch in mind. It is the solution I discussed with
> Erik plus I kept important initialization code on top. AFAICT it would have
> been fine either way, but it is better to have it in this order. Should be
> more robust for future changes.
> The patch is updated to apply to current SVN trunk. It is best to look at
> the changes after they have been applied too.
You are going about this in the wrong way. Instead of moving half of
configure around, which is hard to review, just move the git bits.
I have it done locally, just need to find the time to battle some
shell quoting issues that still appear in there.
More information about the MPlayer-dev-eng