[MPlayer-dev-eng] [PATCH] configure: much faster configure --help
eclipse7 at gmx.net
Mon Feb 11 23:35:46 CET 2013
Erik Auerswald wrote:
> On 02/11/2013 09:32 PM, Alexander Strasser wrote:
> >Erik Auerswald wrote:
> >>MPlayer's configure does a lot of work before checking command line
> >>options. This includes updating of an ffmpeg git repository before
> >>producing help output, even when only asked for help.
> >>The attached patch rearranges configure's help output code to be in
> >>front of ffmpeg repo checks and updates and introduces a new check,
> >>if the first command line option is --help or -h and prints the help
> >>This drastically speeds up checking for available configure options,
> >>if done the common way of "./configure --help". If the --help resp.
> >>-h option is somewhere else on configure's command line, the (kept)
> >>existing check will find this after doing all the initial setup
> >>work, taking much longer overall.
> > sounds useful to me.
> >Instead of using the if-keyword it might be more practical to duplicate the
> >case from the option parsing loop, just with the one entry looking for the
> >help options only.
> Did this in v2.
> > Otherwise LGTM.
> > Alexander
> >Note that I am not the MPlayer configure maintainer.
> I know...
> Thanks for reviewing, maybe someone finds this useful.
Thanks, I have it applied and tested locally.
So if there are no objections within a week I intent to commit it.
More information about the MPlayer-dev-eng