[MPlayer-dev-eng] [PATCH] libvo/x11_common: resize window before mapping it.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Feb 6 19:08:44 CET 2013

On Wed, Feb 06, 2013 at 05:17:00PM +0100, Nicolas George wrote:
> If the window is resized before being mapped, then the
> original size is visible for a fraction of a second.
> It happens with the temporary 320×200 window used by vo_gl
> to determine the display capabilities and causes bad window
> placement decisions from window-managers.

I am working from memory, but I think this has several issues
1) quite a few window managers decide on the position and size upon map,
which means that this change will lead to the values specified via
-geometry being ignored
2) since we try to set size/position before enabling the corresponding
event masks, we will not get the proper notifications. This can lead
to vo_dx/dy/dwidth/dheight being out of sync with the real window size.
This is possibly even more true since vo_x11_update_geometry uses
XGetGeometry etc. to try to figure out the position, which is a strange
thing to do for an unmapped window I think.
3) What window placement decision? As far as I can tell MPlayer
calls XMoveResizeWindow always, so there isn't supposed to be anything
for the window manager to decide...

I am kind of wondering if what your patch does isn't the same as just
removing most to all of that code...

More information about the MPlayer-dev-eng mailing list