[MPlayer-dev-eng] [PATCH] Support for QNX: QSA audio and Photon GUI.

[Reimar Döffinger]

On 5 Feb 2013, at 21:52, Mike Gorchak <mike.gorchak.qnx at gmail.com> wrote:
>> Please use K&R style, i.e.
>> spaces around operators
>> Align a continuing line of a function call with the first character after (.
>> All the { } in your case statements are unnecessary, probably elsewhere as well.
> 
> It is not my codestyle. You a have a great mix of codestyles in the
> mplayer source tree. If you have an indent settings for mplayer rules
> - ok, I will use it before submitting the patches.

indent is too inflexible and unreliable. We have uncrustify rules though:
TOOLS/mp-uncrustify-style.cfg.

> BTW, Look, for example, at the sub/font_load.c - there is plain text
> salad even without proper indents! And no one cares.

Progress is slow, it is basically "enforced" only on new files, and the intention is to be aligned with FFmpeg.

>> The _t namespace is reserved for POSIX, don't invade it.
>> Just drop the typedef, typedeffing structs is not a good
>> idea most of the time anyway...
> 
> Really? Look at the mplayer source (here is the only first three files):

That does not contradict what he said. We have lots of horrible old code. Which is all the more reason why we really want new code to be a lot better. Because we experienced quite well how hard it is to get code in shape afterwards, usually when the original author has disappeared ages ago.
I'll admit that we certainly overdo it sometimes though.

Reimar