[MPlayer-dev-eng] [PATCH] Support for QNX: QSA audio and Photon GUI.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 5 21:29:58 CET 2013

On Tue, Feb 05, 2013 at 09:26:56PM +0200, Mike Gorchak wrote:
> I agree. Could you apply this patch as is and within a week I will
> send an improved version of vo_photon including these fixes and many
> other.

I'd rather have the code in as good shape as reasonable before applying
There are usually still more than enough bugs even so, and particularly
with code I can't test I don't like lightly taking on the responsibility
of having it in the official repository.

> +    def_alsa='#define CONFIG_QSA 1'

I think you meant def_qsa both here and in the undef case.
Also I think it would be better to move the
> if test "$_qsa" = yes ; then
outside the
> if qnx
so that def_qsa is always set to something even on Linux
(where the test won't be run though).

More information about the MPlayer-dev-eng mailing list