[MPlayer-dev-eng] [PATCH] Support for QNX: QSA audio and Photon GUI.

[Mike Gorchak]

Hi Reimar,

> While I was wrong, so are you unfortunately, on a Linux system:
> $ cat /usr/include/sys/asoundlib.h
> #warning This header is deprecated, use <alsa/asoundlib.h> instead.
> #include <alsa/asoundlib.h>
> This means that QSA code will be enable in a Linux system.

You are right, some linux distros still maintain asoundlib.h in sys
subdir. I've added check for QNX platform before perform QSA check.

+if qnx; then
+fi

Please, check new patch in the attachment.

>> > In fact, your ao_qsa seems to simply reimplement ao_alsa?!?!
>> No, QSA is based on ALSA 0.5 API, but not the ALSA source (FYI when
>> mplayer had ao_alsa5 module - it does not work well in QSA
>> environment). But further improvements of QSA made it uncompatible
>> with ALSA 0.5.
> If it's not compatible they really would have done better
> to come up with their own header.

It is a long story. In two words, it was supposed to use ALSA
unmodified in QNX environment, but ALSA developers refused to release
code using some non-GPL license, since QNX has many proprietary audio
drivers. So that's why whole services and libraries were rewritten
from scratch. For the first time it was 100% compatible, but later
compatibility was lost.

>> >> +    switch (photon_mplayer_format)
>> >> +    {
>> >> +        case IMGFMT_YUY2:
>> >> +        case IMGFMT_YVYU:
>> >
>> > I think you should be able to avoid this switch and reduce the code
>> > size a lot by using vo_get_draw_alpha.
>>
>> Yes, but vo_get_draw_alpha does not support V422 format and some other
>> which will be added later.
>
> You can still use it for those format where it works,
> this kind of 100s of duplicated lines that really does some
> very simple stuff is a maintenance horror.

I agree. Could you apply this patch as is and within a week I will
send an improved version of vo_photon including these fixes and many
other.

Thanks in advance!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-qnx-aovo.diff
Type: application/octet-stream
Size: 79492 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130205/7327b949/attachment-0001.obj>