[MPlayer-dev-eng] [PATCH] Add audio support for sndio API.

[Reimar Döffinger]

On 07.12.2013, at 00:36, Brad Smith <brad at comstyle.com> wrote:
> On 06/12/13 3:10 PM, Reimar Döffinger wrote:
>> Hello,
>> This should be added to the documentation, too.
> 
> Ok.
> 
>> On Fri, Dec 06, 2013 at 12:40:20AM -0500, Brad Smith wrote:
>> 
>>> +if test "$_sndio" = yes ; then
>> 
>> Lots of trailing whitespace, also in the .c file.
>> If I remember right, it is not even possible to commit
>> before this is fixed.
>> To be consistent with FFmpeg, 4 spaces indentation would
>> be somewhat preferable over tabs, too.
> 
> Ok, this is a BSD style of code with regard to tabs vs spaces. I
> will pass on your feedback to Alexandre to see about having fixes
> and such incorporated.
> 
> Just FYI this is the same backend I was attempting to submit here
> 
> http://marc.info/?l=mplayer-dev-eng&w=2&r=1&s=sndio&q=b
> 
> I am not the author but I am someone who helps to maintain the OpenBSD
> MPlayer port/package. The intention is to have the backend go through
> the feedback / fixes / submit for further review loop until it is in
> good enough shape to be commited and so it is not sitting in our ports
> tree. This is the only thing we have in our ports tree of any
> significance for MPlayer.

It's appreciated, though of course the extra indirection isn't going to make the process any easier.
I see that some things were fixed from the previous review, some weren't and some things are new e.g. due to new helper functions in MPlayer.