[MPlayer-dev-eng] [PATCH] Fix FOURCC format check in mplayer.c

compn tempn at twmi.rr.com
Wed Aug 14 01:05:59 CEST 2013

On Wed, 14 Aug 2013 00:46:47 +0200, Hans-Dieter Kosch wrote:
>some time ago I sent a patch to fix FOURCC format check in mplayer.c;
>there was no response yet, so I send it again.
>The comment in the code says:
>/* Assume FOURCC if all bytes >= 0x20 (' ') */
>But this can only work if it is checked byte by byte instead of a single long 
>word (e.g. 0x2020211f >= 0x20202020 holds falsely true).

is this only used in the -identify option?
mencoder doesnt have all this stuff.


More information about the MPlayer-dev-eng mailing list