[MPlayer-dev-eng] Should there be movie_aspect and stricter prescaling checks?

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Aug 7 08:59:47 CEST 2013

"Ingo Brückl" <ib at wupperonline.de> wrote:
>Option "aspect" (variable movie_aspect) is restricted to range
>0.1..10.0 in
>Command switch_ratio allows any value for movie_aspect in command.c and
>is already prescaling for sh->aspect > 0.01 in vd.c.
>Should there be checks for the above range and prescaling only start if
>greater or equal 0.1, or is it ok for the switch_ratio command to leave
>range of the aspect option? Should the range start with 0.01?

I think it is reasonable for the command line to be more restricted.
A typo or misunderstanding can lead to a window that might be hard to handle or (as we noticed in ffplay with SDL) cause crashes.
Not that I mind much in the end.

More information about the MPlayer-dev-eng mailing list