[MPlayer-dev-eng] [PATCH] make clean should remove all files generated by make

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Sep 24 19:32:06 CEST 2012


Hello,
I don't know what the idea behind the current split between "clean"
and "distclean" is.
But IMHO "make clean" should remove all files that "make" can
regenerate, only leaving stuff e.g. generated by configure.
Do you agree?

Index: Makefile
===================================================================
--- Makefile	(revision 35213)
+++ Makefile	(working copy)
@@ -972,17 +972,17 @@
 clean:
 	-$(MAKE) -C ffmpeg $@
 	-rm -rf tests/res
-	-rm -f $(call ADD_ALL_DIRS,/*.o /*.a /*.ho /*~)
+	-rm -f $(call ADD_ALL_DIRS,/*.o /*.d /*.a /*.ho /*~)
 	-rm -f $(call ADD_ALL_EXESUFS,mplayer mencoder)
+	-rm -f $(VIDIX_PCI_FILES)
+	-rm -f $(call ADD_ALL_EXESUFS,codec-cfg cpuinfo)
+	-rm -f codecs.conf.h help_mp.h version.h
+	-rm -f DOCS/xml/html-chunk.xsl DOCS/xml/html-single.xsl
 	-rm -rf DOCS/tech/doxygen DOCS/HTML
 
 distclean: clean testsclean toolsclean driversclean dhahelperclean
 	-$(MAKE) -C ffmpeg $@
-	-rm -f DOCS/xml/html-chunk.xsl DOCS/xml/html-single.xsl
-	-rm -f $(call ADD_ALL_DIRS,/*.d)
-	-rm -f config.* codecs.conf.h help_mp.h version.h TAGS tags
-	-rm -f $(VIDIX_PCI_FILES)
-	-rm -f $(call ADD_ALL_EXESUFS,codec-cfg cpuinfo)
+	-rm -f config.* TAGS tags
 
 doxygen:
 	doxygen DOCS/tech/Doxyfile


More information about the MPlayer-dev-eng mailing list