[MPlayer-dev-eng] [PATCH] vf_ass: remove READABLE flag

[Xidorn Quan]

On Wed, Sep 5, 2012 at 2:55 PM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On 5 Sep 2012, at 03:45, Xidorn Quan <quanxunzhen at gmail.com> wrote:
>> Hi,
>>
>> I read the comment for MP_IMGFLAG_READABLE, and didn't think that
>> vf_ass need a buffer to be readable across frames. It always requests
>> a new buffer in get_image or put_image. Additionally, IMGTYPE_TEMP
>> also indicates that buffer can be write-only.
>
> I think that comment is misleading. READABLE at least nowadays is also used to indicate that a significant amount of data will be read by the filter.
> Its purpose is to indicate that using non-cacheable video memory as a backing buffer would be a really bad idea.

Well, so please update comments in time to prevent such misleading.