[MPlayer-dev-eng] [PATCH] DR support for vo_corevideo

[Reimar Döffinger]

On Tue, Sep 04, 2012 at 10:48:37AM +0800, Xidorn Quan wrote:
> Hi,
> 
> This patch enables Direct Rendering support for vo_corevideo.

It's not so easy at all.
The decoder can request lots of buffers that are all in use
at the same time, if you can provide only one like here you
need to make sure you fail if you've already given out one.
I also don't think you should remove the DRAW_CALLBACK flag
in get_image, and the DRAW_CALLBACK flag is the better flag
to check to skip the memcpy.
vo_gl should be doing it _mostly_ right, but it's rather difficult.
In addition you would also have to handle the following sequence:
get_image for image A
data for image A is written
draw_image for image B
draw_image for image A