[MPlayer-dev-eng] [PATCH] Fix a bunch of fresh -Wundef warnings...

[Erik Auerswald]

Hi Alexander,

On 10/28/2012 01:44 AM, Alexander Strasser wrote:
> Erik Auerswald wrote:
>> On 10/25/2012 10:51 PM, Erik Auerswald wrote:
>>> compiling a current svn checkout of MPlayer with a current git clone of
>>> FFmpeg shows the following new warnings:
>>>
>>> libavutil/libm.h:36:6: warning: "HAVE_ATANF" is not defined [-Wundef]
>>> libavutil/libm.h:41:6: warning: "HAVE_ATAN2F" is not defined [-Wundef]
>>> libavutil/libm.h:46:6: warning: "HAVE_POWF" is not defined [-Wundef]
>>> libavutil/libm.h:58:6: warning: "HAVE_COSF" is not defined [-Wundef]
>>> libavutil/libm.h:63:6: warning: "HAVE_EXPF" is not defined [-Wundef]
>>> libavutil/libm.h:98:6: warning: "HAVE_LDEXPF" is not defined [-Wundef]
>>> libavutil/libm.h:123:6: warning: "HAVE_LOG10F" is not defined [-Wundef]
>>> libavutil/libm.h:128:6: warning: "HAVE_SINF" is not defined [-Wundef]
>>>
>>> Seems some new FFmpeg #defines that need to be added somewhere™. Does
>>> anybody know where new FFmpeg feature test macros are supposed to be
>>> added? More specific than "to configure", please. ;-)
>>
>> The attached patch adds checks to create the above HAVE_* defines to
>> configure. The many silenced warnings show additional missing HAVE_*
>> defines...
>
>    your patch looks good to me.

Thanks for looking into the issue. :-)

 > Also if I am not too tired it actually
> does fix a few wrong decisions (on some systems libm.h will redefine
> math functions that are actually there) as opposed to only silencing
> warnings.

I thought so, but did not check and thus did not claim more than fixing 
warnings. I did test that the defines are sensible (all functions 
detected on my system) and the resulting MPlayer still works for me... ;-)

>    I will commit Sunday evening if I hear no objections.

Thanks,
Erik