[MPlayer-dev-eng] [PATCH] two independent patches for configure

[Alexander Strasser]

Xidorn Quan wrote:
[...]
> Index: configure
> ===================================================================
> --- configure	(revision 35235)
> +++ configure	(working copy)
> @@ -1581,9 +1581,6 @@
>  
>  if darwin; then
>    extra_cflags="-mdynamic-no-pic $extra_cflags"
> -  if test "$(basename $_cc)" != "clang" ; then
> -    extra_cflags="-falign-loops=16 -shared-libgcc $extra_cflags"
> -  fi
>    _timer=timer-darwin.c
>  fi
>  
> @@ -1729,6 +1726,10 @@
>  fi # icc
>  test "$cc_fail" = yes && die "unsupported compiler version"
>  
> +if darwin && test "$cc_vendor" != "clang" ; then
> +  extra_cflags="-falign-loops=16 -shared-libgcc $extra_cflags"
> +fi
> +

  I am about to apply this. But while digging up history doubts came
up this is still needed?

  So does anyone reading this successfully compile with gcc on osx
and does it really need -falign-loops=16 -shared-libgcc ?

  From what I read in the commit log the

    -falign-loops=16 recommended flags on osx
    -shared-libgcc   fix missing symbol when compiling with live support on mac osx

  If none of those are needed anymore, it might be better to just
not set these flags. If I do not hear any news on this soon I will
just go with the patch as it helps people compiling with clang as
cc. Can still be removed later though if anyone can confirm those
flags are not needed anymore.

  Alexander