[MPlayer-dev-eng] [PATCH] deinterlace property fix

[Alexander Strasser]

Alexander Strasser wrote:
> Vicente Sendra wrote:
> > I've previously send a fix for command.c in:
> > Better double frame rate output and framedrop
> > 
> > But there was a bug in my code.
> > 
> > This new one fixes old problem:
> > 
> > Better handling of deinterlace property, returns M_PROPERTY_ERROR if it can't be changed (or read), and displays osd value correctly (when change was not successful it showed the opposite value).
> > 
> > And my bug:
> > 
> > if VFCTRL_GET_DEINTERLACE was not successfull, deinterlace value was undefined.
> > 
> > I send it as a separate fix, as it's unrelated to new framedrop system.
> 
>   thanks for splitting and submitting separately!
> 
>   I tested your patch and changed some minor mostly naming things.
> Your patch works out for me in that the behaviour of the OSD is
> improved. I attached the modified patch including the planned
> commit message.
> 
>   I am somewhat unsure about the semantics of the return code though.
> Should we really return M_PROPERTY_ERROR? At least when it is not
> supported in the filter chain it generates some confusing noise in
> mplayer's console output.
> 
>   Sorry for the delay, but I want to think about this a little bit
> more. If I come to no good conclusion I will commit your patch as
> attached in the hope that if there are better ways to do it they will
> be implemented on top of your change eventually.

  Partially committed.

  I only committed the part relevant for the OSD output. After
looking at other properties implemented in command.c I came to
the conclusion that returning M_PROPERTY_ERROR is probably not
the correct thing to do here. If it is a problem for you please
explain me your use case.

  Thank you for your contribution!

[...]

  Alexander