[MPlayer-dev-eng] [PATCH] patch for af_hrtf to relieve noises

[Xidorn Quan]

On Sun, Oct 21, 2012 at 2:35 AM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de>wrote:

> On Sat, Oct 20, 2012 at 11:21:32PM +0800, Xidorn Quan wrote:
> > Hi,
> >
> > A simple patch is attached which is intend to relieve noises for
> > af_hrtf by using clamp instead of casting directly.
>
> Not sure if overflows are supposed to be possible, it might just hide
> an issue somewhere else.
>

Well, I think it is true that it hides an issue somewhere else since
there are still some noises after clamping when remixing stereo. This
patch only relieve some of the noises.

I may work on it if I have time to debug.


> But if nobody has a different opinion I think that is ok, but please
> use the appropriate av_clip_* function from libavutil, in some cases
> it can be a lot faster.
>

OK, I'll submit another patch later today.

BTW, I think it would make it much faster to rearrange the structure
of loops which could let the compiler make more optimization. Many
other afs and vfs can also be optimized this way I think.

Regards,
Xidorn Quan