[MPlayer-dev-eng] [PATCH] deinterlace property fix

[Alexander Strasser]

Hi Vicente,

Vicente Sendra wrote:
> I've previously send a fix for command.c in:
> Better double frame rate output and framedrop
> 
> But there was a bug in my code.
> 
> This new one fixes old problem:
> 
> Better handling of deinterlace property, returns M_PROPERTY_ERROR if it can't be changed (or read), and displays osd value correctly (when change was not successful it showed the opposite value).
> 
> And my bug:
> 
> if VFCTRL_GET_DEINTERLACE was not successfull, deinterlace value was undefined.
> 
> I send it as a separate fix, as it's unrelated to new framedrop system.

  thanks for splitting and submitting separately!

  I tested your patch and changed some minor mostly naming things.
Your patch works out for me in that the behaviour of the OSD is
improved. I attached the modified patch including the planned
commit message.

  I am somewhat unsure about the semantics of the return code though.
Should we really return M_PROPERTY_ERROR? At least when it is not
supported in the filter chain it generates some confusing noise in
mplayer's console output.

  Sorry for the delay, but I want to think about this a little bit
more. If I come to no good conclusion I will commit your patch as
attached in the hope that if there are better ways to do it they will
be implemented on top of your change eventually.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mp_property_deinterlace-Handle-failures-correctly.patch
Type: text/x-diff
Size: 2442 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20121013/35b0529a/attachment.bin>