[MPlayer-dev-eng] [PATCH] corevideo:shared_buffer broken (patch attached)

[Reimar Döffinger]

On Wed, Oct 10, 2012 at 11:56:33AM +0000, Zongyao Qu wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
> > Should be ok as a quick fix, but I suspect it might cause some strange
> > effects if -fs is used with shared buffer.
> > I think a better solution would be to set vo_screenwidth/height to some
> > fallback value if they are 0.
> > 
> 
> diff --git libvo/vo_corevideo.m libvo/vo_corevideo.m
> index a89f25d0e218395f3c997199129646dbb720b7d2..6ef9c0193a0763
> a7ef362d71e4f56ab4b4261f09 100644
> --- libvo/vo_corevideo.m
> +++ libvo/vo_corevideo.m
> @@ -117,6 +117,16 @@ static void free_file_specific(void)
>      }
>  }
>  
> +static void update_screen_info_shared_buffer(void)
> +{
> +	NSRect rc = [[NSScreen mainScreen] frame];
> +	vo_screenwidth = (int)rc.size.width;
> +	vo_screenheight = (int)rc.size.height;
> +	xinerama_x = (int)rc.origin.x;
> +	xinerama_y = (int)rc.origin.y;

I don't think the casts should be necessary?
Otherwise looks good to me.