[MPlayer-dev-eng] [PATCH2] corevideo:shared_buffer broken

[Reimar Döffinger]

On Wed, Oct 10, 2012 at 02:36:22AM +0000, Zongyao Qu wrote:
> > Should be ok as a quick fix, but I suspect it might cause some strange effects
> > if -fs is used with shared buffer.
> > I think a better solution would be to set vo_screenwidth/height to some
> > fallback value if they are 0.
> > 
> 
> Followup:
> 
> If update_screen_info returned TRUE, aspect() is called(video_out.c:369).
> then aspect_fit() is called(aspect.c:149).
> In aspect_fit(), static variables aspdat.scrw/scrh are used.
> 
> aspdat.scrw/scrh are set and only be set by function aspect_save_screenres().
> 
> Conclusively, calling aspect() implies that aspect_save_screenres() has been
>  called, at least once, which is true for most vo, but not for shared_buffer.
> 
> Then, in libvo.txt, it says xinerama_x, xinerama_y, vo_screenwidth and
> vo_screenheight should be set, and aspect_save_screenres() is not mentioned.
> 
> So the first question is, aspect_save_screenres() should be called inside of vo,
> or outside?
> --if inside, we should update our doc.

Yes, I think that would be the right thing to do.