[MPlayer-dev-eng] [PATCH] mplayer: Fix building GUI without DVD support

[Reimar Döffinger]

"Ingo Brückl" <ib at wupperonline.de> wrote:

>Valentine Barshak wrote on Mon, 8 Oct 2012 22:34:48 +0400:
>
>> This patch fixes the following compilation error
>> when building GUI mplayer without DVD support:
>>   gui/interface.o: In function `gui':
>>   interface.c:(.text+0xbd4): undefined reference to `dvd_angle'
>>   interface.c:(.text+0x1199): undefined reference to `dvd_angle'
>
>Reimar,
>
>would that be OK with you or should I rather #ifdef CONFIG_DVDREAD
>everything
>with dvd_title, dvd_chapter and dvd_angle in the GUI sources? (We could
>then
>move the definitions of dvd_title and dvd_chapter to a proper place.)

 The GUI should not be using any of these directly, instead use stream controls. Even more so since using the variables directly to my knowledge will not work when the cache is enabled.
But otherwise I'd prefer ifdefs in the GUI code.