[MPlayer-dev-eng] [PATCH] corevideo:shared_buffer broken

[Xidorn Quan]

On Mon, Oct 8, 2012 at 9:08 PM, Zongyao Qu <zongyao.qu at gmail.com> wrote:

> Sorry I am just too lazy to make a serious patch,
> since I have too many local changes in the source code.
>
> I will point out where the bug is
>
> In
> static int control(uint32_t request, void *data)
>
> please change this line
>
> case VOCTRL_UPDATE_SCREENINFO: [mpGLView update_screen_info]; return
> VO_TRUE;
>
> to
>
> case VOCTRL_UPDATE_SCREENINFO: if(!shared_buffer){[mpGLView
> update_screen_info];
> return VO_TRUE;};
>
> -----------------
> When shared_buffer is used, mpGLView will be nil, so that the code before
> this fix will result unknown behavior.
>

I don't think it is where the problem is since nil can accept any
message and simply ignore them without complaining.

On the other hand, when shared buffer is used, rendering process should be
> totally controlled by GUI process, so I think it is OK to just return
> VO_NOTIMPL.
>