[MPlayer-dev-eng] [PATCH] GUI: Corrections for display of video size and track number, playlist

[Ingo Brückl]

Hans-Dieter Kosch wrote on Fri, 30 Nov 2012 03:09:14 +0100:

> Reimar Döffinger wrote:
>> On Thu, Nov 29, 2012 at 01:54:47AM +0100, Hans-Dieter Kosch wrote:
>>> The reason for I did it in one step is that I do 'svn diff' against
>>> the latest SVN revision. If I split it, and one diff is treated, the
>>> line numbers in the next diff are incorrect.
>>
>> Note that incorrect line numbers are not a problem (one of the reasons
>> for using unified diff format), as long as that is all.

> Yes, I know. The 'patch' program handles huge line deviations as long as
> enough context is provided (and a human can handle even more). But it seems
> inconvenient to me for human reading.

This is exactly why patches covering only one issue a time are preferred.

Unlike in other projects I've been working in, MPlayer commit patches are
easy to read, even if you don't know much about the code that is being
patched.

Ingo