[MPlayer-dev-eng] [PATCH] GUI: Corrections for display of video size and track number, playlist pos

[Hans-Dieter Kosch]

Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Tue, 27 Nov 2012 02:56:10 +0100:
> 
>> attached my next patch suggestions.
> 
> Please provide separate patches for each different (class of) issue(s), not
> a bunch of fixes in one big patch.
> 
> From skimming your changelog I suppose that there might be at least the
> following different issue (maybe more): video size, track number, playlist
> position, variable reset issues (at different stages of program flow).
> 
> The paragraphs you've used in your changelog might give you good idea what
> could be a single patch (but I'm not saying that it has to be so).
> 
> I'm looking forward to your patches.
> 
OK. I'll split it up. I'm not familiar with your patch codex (from 'svn log' can 
be seen that it's very detailed).
The reason for I did it in one step is that I do 'svn diff' against the latest 
SVN revision. If I split it, and one diff is treated, the line numbers in the 
next diff are incorrect. I could make step by step 'diff -u' against previous 
change, or wait until one diff is treated and then update working copy and post 
the next.
What do you propose?

BTW: Is there a preferred coding style? E.g. placing of opening braces (at end 
of line or on separate line), indentation rules, ...
Of course, when I patch a file, I try to use the style therein.

Hans-Dieter