[MPlayer-dev-eng] [PATCH] GUI: Fix blocking after end of file when trying to play file/stream/playl

[Ingo Brückl]

Hans-Dieter Kosch wrote on Sun, 25 Nov 2012 03:11:24 +0100:

> the blocking is not yet fully solved. If the playlist has been cleared
> during session, after the next end of file we still run into the "filename
> == NULL" blocking when we select PLAY

And there is even more: STOP, clearing the list and PLAY will also hang.

> The attached patch fixes this (hopefully, this time I better hit the goal).

Almost. ;-)

> PS: There's some weirdness in displaying track number and video size, next
> patch to be expected soon. Editing playlist has also some issues, but this
> is future work...

Track number and playlist editing I know (there are a few bugs on my list),
but video size?

> +                 guiInfo.StreamType == STREAMTYPE_PLAYLIST) &&

STREAMTYPE_PLAYLIST is just an intermediate type to communicate with MPlayer
which is so kind to resolve the list then. At this stage, this type no longer
exists.

> +                !listMgr(PLAYLIST_GET, 0)) {

CURR is better.

> +                guiInfo.Filename   = NULL;

guiInfo.Filename is a strdup'ed value and must be freed.

> -            guiInfo.Track   = 1;
> +            guiInfo.Track   = (guiInfo.StreamType == STREAMTYPE_DUMMY) ? 0 : 1;

Let's postpone this until we fix the track issues.

I hope I've fixed it in r35475.

Ingo