[MPlayer-dev-eng] [PATCH] GUI: Fix blocking after end of file when replaying a single file

[Hans-Dieter Kosch]

Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Thu, 22 Nov 2012 01:29:12 +0100:
> 
>> Ingo Brückl wrote:
>>> Hans-Dieter Kosch wrote on Wed, 21 Nov 2012 01:45:46 +0100:
>>>
>>>> Fix blocking of GUI after end of file when replaying a single file:
>>>> Don't clear 'filename' but retain it.
>>> There is a bug (thanks for reporting), but this isn't the solution. Please
>>> stay tuned.
>>>
>> I'm quite new to the mplayer code and I already guessed, that it's not that
>> simple:
> 
> Your patch helped me to immediately recognize what the problem is and how to
> fix it. A bug report without your patch would have caused me to do a lot of
> debugging.
> 
I can imagine that; it took me considerable debugging to find my imperfect solution.

>> There's interaction between 'filename' and 'guiInfo.Filename' (of course);
>> moreover, 'filename' is a global variable
> 
> This is, because there isn't yet a clear separation between GUI and MPlayer
> code. Although the GUI tries to be on its own with own variables and such, it
> currently has to use some global MPlayer variables until there is a clearly
> defined interface between them (which, however, is work in progress).
> 
> In case of 'filename', the GUI has to set it in order to "use MPlayer as a
> playback engine", but it does set it from its playlist.
> 
Thanks, these explanations improve my understanding.

Hans-Dieter