[MPlayer-dev-eng] [PATCH 0/7] stream ftp: Support longer file names

[Alexander Strasser]

Hello again!

  I will wait a bit longer for more comments/testing.

  Thank you for your comments Reimar! They will be addressed.

  I may post a reroll of this series if more substantial
modifications need to be made.

  Alexander

Alexander Strasser wrote:
> Due to the concerns raised recently about long file names with
> stream ftp, this series aims to make longer ones possible.
> 
>   After the first 6 patches are applied it is finally possible
> to change the command buffer size which is mainly responsible
> for the supported file name length. I increase that size in
> patch 7. But I still had some problems with very long file
> names at some point when testing here locally. But I could
> use much longer names than are supported now. Seems to be a
> server problem but I am not very sure about it.
> 
>   So testing is very welcome especially with long names and
> with different FTP servers at the remote end.
> 
>   I also would welcome code reviews on this.
> 
> Alexander Strasser (7):
>   stream ftp: readline: Fix off-by-one error
>   stream ftp: readline: Always initialize output parameter buf
>   stream ftp: readline: Always try to read complete lines
>   stream ftp: Only send QUIT command if connected
>   stream ftp: Create buffers before opening control connection
>   stream ftp: Allocate command buffer on-heap
>   stream ftp: Increase command buffer size
> 
>  stream/stream_ftp.c | 96 ++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 69 insertions(+), 27 deletions(-)