[MPlayer-dev-eng] [Suggested PATCH] Increase maximum ftp file path length

Alexander Strasser eclipse7 at gmx.net
Mon Nov 5 22:10:46 CET 2012


Hello Sergey!

Sergey wrote:
> I often use mplayer to watch video recordings from our local ftp
> server. And I noticed that mplayer is unable to show long ftp urls.
> I had to wget them and watch locally.
> 
> Steps to reproduce:
>   mplayer -v 'ftp://62.76.7.10/pub/Big Buck
> Bunny////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////big_buck_bunny_480p_stereo.avi'
> 
> It appeared that mplayer limits length of the ftp path to 256
> characters (actually it's about 200 chars), but for UTF file names
> it's almost 100 characters. That was not good.

  Thanks for looking into the problem. I share your opinion that the
buffer is too small for lots of not very unusual use cases (even more
so considering different cultural circumstances).

> Attached patch fixed the issue for me.

  Regarding the patch I agree with Xidorn's and Nicolas' comments. I
have started looking into that file and will try to implement a better
solution. I expect it will be available at the end of this week.

  It would be great if you could test it then.

[patch snipped]

  Alexander


More information about the MPlayer-dev-eng mailing list