[MPlayer-dev-eng] [Suggested PATCH] Increase maximum ftp file path length

Xidorn Quan quanxunzhen at gmail.com
Mon Nov 5 06:19:19 CET 2012


On Mon, Nov 5, 2012 at 1:04 PM, Zongyao Qu <zongyao.qu at gmail.com> wrote:

> >> -    static char response[256];
> >> +    static char response[65536];
>
> static means it is not in stack, but static memory.
>

Well, you are right, but...

@@ -233,7 +233,7 @@
>
>  static int FtpOpenPort(struct stream_priv_s* p) {
>    int resp,fd;
> -  char rsp_txt[256];
> +  char rsp_txt[65536];
>    char* par,str[128];
>    int num[6];
>

@@ -312,7 +312,7 @@
>  static int seek(stream_t *s,off_t newpos) {
>    struct stream_priv_s* p = s->priv;
>    int resp;
> -  char rsp_txt[256];
> +  char rsp_txt[65536];
>


> @@ -389,7 +389,7 @@
>    int resp;
>    int64_t len = 0;
>    struct stream_priv_s* p = (struct stream_priv_s*)opts;
> -  char str[256],rsp_txt[256];
> +  char str[65536],rsp_txt[65536];


are all in stack.


More information about the MPlayer-dev-eng mailing list