[MPlayer-dev-eng] [Suggested PATCH] Increase maximum ftp file path length

Xidorn Quan quanxunzhen at gmail.com
Mon Nov 5 06:00:15 CET 2012


On Mon, Nov 5, 2012 at 10:28 AM, Sergey <sergemp at mail.ru> wrote:

> 64K ought to be enough for anybody.
> --- stream/stream_ftp.c.orig    2012-07-11 02:07:30.000000000 +0300
> +++ stream/stream_ftp.c    2012-07-11 02:11:43.000000000 +0300
> @@ -178,11 +178,11 @@
>   */
>  static int readresp(struct stream_priv_s* ctl,char* rsp)
>  {
> -    static char response[256];
> +    static char response[65536];
>      char match[5];
>      int r;
>

I don't think it's a good idea to put such a large array in stack.


More information about the MPlayer-dev-eng mailing list