[MPlayer-dev-eng] [PATCH] vd_null to output black frames

[Xidorn Quan]

On Sat, Nov 3, 2012 at 8:25 PM, Alexander Strasser <eclipse7 at gmx.net> wrote:

> Xidorn Quan wrote:
> > On Sat, Nov 3, 2012 at 9:20 AM, Alexander Strasser wrote:
> > > Alexander Strasser wrote:
> > > >   I also like Xidorn's idea of never choosing the decoder because it
> > > > is flagged "dummy" and having the status set to "working" again for
> > > > null and black. It would eliminate the misuse of the status property.
> > > >
> > > >   Reimar, what do you think?
> > >
> > >   Attached is a *not* very well tested RFC patch to implement the
> > > behavior Xidorn described above. It must be applied incrementally
> > > on top of Xidorn's patch.
> > >
> > >   I am unsure if this change of behavior has any additional (high
> > > level) consequences I am not aware of.
> >
> >
> > Well, in fact I have implemented this behavior in my local repo, and
> > just forgot to send the patch.
> >
> > The patch attached includes my prevous patch, and it implements the
> > behavior in a different way. I think it should be more safe to keep
> > changes inside codec-cfg instead of modifying both dec_audio and
> > dec_video.
>
>   I share your opinion that having it in a single place in codec-cfg
> feels safer.
>
>   Let me explain why I changed it in dec_audio/video. I fear if we
> go with your solution e.g. "-vc null" would not work anymore. But
> I might have missed something. The code regarding codec selection
> and codecs.conf is tricky to say the least.
>
>   So if I am right and we need to use "-vc +null" with your solution,
> than that should definitely be discussed further and will need more
> changes regarding documentation.
>

Well, you are right. Your patch looks good to me.

Xidorn Quan