[MPlayer-dev-eng] [PATCH] ralf support with native demuxer

[Reimar Döffinger]

On Fri, May 25, 2012 at 12:37:18AM +0200, Roberto Togni wrote:
> I'll apply it in a few days if no comments (and if my svn account still
> works).

It should, and nice to see you're still around :-)
I think you can just go ahead and commit.

> +		    sh->wf->nChannels = 0;//sh->channels;
> +		    sh->wf->wBitsPerSample = 16;
> +		    sh->wf->nSamplesPerSec = 0;//sh->samplerate;
> +		    sh->wf->nAvgBytesPerSec = 0;//bitrate;
> +		    sh->wf->nBlockAlign = 0;//frame_size;

I don't see the point of the comments though.

> +		    stream_read(demuxer->stream, ((char*)(sh->wf+1)), codec_data_size);

The outermost () are not really necessary.

> +		    if(demuxer->audio->id==stream_id){
> +			    sh->ds=demuxer->audio;
> +			    demuxer->audio->sh=sh;
> +		    }

Since that's probably a copy from other code in the file it's kind of unrelated,
but I think this kind of code shouldn't be necessary anymore, it is
already handled in new_sh_audio nowadays.