[MPlayer-dev-eng] [PATCH] Plaintext playlist parsing

[Reimar Döffinger]

On Tue, May 22, 2012 at 11:18:44AM +0200, Ingo Brückl wrote:
> I wrote on Tue, 22 May 2012 00:24:34 +0200:
> 
> > Is this patch ok or should it be somehow restricted to the GUI (use_gui)?
> 
> Yeah, I think
> 
>   entry      = parse_playtree(mpctx->stream, use_gui);
> 
> is probably much better, because it doesn't change the current (non-GUI)
> behaviour.

I am not sure this is a good idea at all, even for the GUI.
The problem is that there is no sanity checking at all for plain text
playlist.
Imagine if someone by accident gets a DVD image in there, I am sure
really bad things will happen (like a few million or so playlist
entries, using up loads of memory, swapping, possibly even
out-of-memory crashes).
At least I really hate it when programs can't deal with me having
too thick fingers and click on the wrong file (since I don't use
gmplayer I don't really care, but still).