[MPlayer-dev-eng] [PATCH] update ad_mpg123 in preparation to replace mp3lib

[compn]

On Thu, 15 Mar 2012 10:18:37 +0100, Thomas Orgis wrote:
>Am Wed, 14 Mar 2012 19:26:59 -0400
>schrieb compn <tempn at twmi.rr.com>: 
>
>> >Nothing prevents those systems from having a system mpg123.
>> 
>> " 1. New installation via GNU autotools "
>> 
>> installing autotools is never fun. or easy.
>> 
>> (i wonder why step 2 is in the INSTALL at all?)
>> and 0. Prerequesites
>> does not list autotools crap at all!
>
>Well, perhaps I subsumed that under "an (UNIX-like) operating system
>with standard tools". While I do agree that autotools has a lot of "it
>sucks"-points for the developer, it is quite a strong standard for
>users wanting to build things. Even MPlayer's configure && make does
>mimic basic autotools usage, nay?
>
>And if you just want to install a mpg123 release (or
>http://mpg123.org/snapshot), you do not need autotools installed. Just
>run configure and make and be happy.

ah thats cool.

>I get the message that I should rewrite the INSTALL file to more
>properly reflect the current state of things; mentioning also how one
>manages to get a build from SVN. I did omit that, sorry. 

well, just trying to help :)

>While I also dislike autotools and don't use it for other projects, the
>mpg123 build system is there, it works. I'd need a serious flash of
>leisure time to rework that again (and reimplement all it offers). Is it
>_really_ a hindrance? The stuff is a PITA for devs, but it also
>_works_ for users, including cross builds.
>
>So I take it you are against inclusion of libmpg123 in MPlayer tree to
>avoid autotool contamination?


mpg123 wont be an svn external or copied into the source, so none of my
complaints matter much.


>> a better idea would be to have a distro dump it, so we can get bug
>> reports without affecting all users.
>
>You are talking about talking one distro into patching out mp3lib to
>form the bleeding edge? This is strange. If there is a change in
>MPlayer to do, MPlayer upstream should do it, with reasonable testing
>that it doesn't break things. Distros have their separate testing
>cycles and work in addition to that.

i'm sorry, i'm just trolling a little bit. i've had afm=ffmpeg in my
config for years, so i havent used mp3lib/mpglib. feel free to
remove it.

-compn