[MPlayer-dev-eng] [PATCH] update ad_mpg123 in preparation to replace mp3lib

[Thomas Orgis]

Am Wed, 14 Mar 2012 10:35:08 +0100
schrieb Diego Biurrun <diego at biurrun.de>: 

> > would be nice if we made it svn external or included a copy. i'm just
> > complaining since mac and mingw wont have a system mpg123...
> 
> Nothing prevents those systems from having a system mpg123.

It builds on those systems and actually we offer binaries built with
mingw on http://mpg123.org/download/win{32,64}/. I don't have a strong
opinion on svn:external, do as you please*; but including a copy would
mean that I have to poke you folks if there should be an update:-/

> > before mp3lib is retired:
> > 1. make sure mpg123 builds on all systems mplayer builds on (amiga,
> > os/2 , arm, bsd, etc).

Reasonable. I know of a user running it on OS/2 and occasionally
telling me when something's broken. It's fine on ARM systems (debian,
usually), BSDs are also cool. I don't know about Amiga.

> > 2. run it on all of our mp3 samples , with ao pcm + md5 checking of
> > output. on all of those systems...
> 
> Ugh, no, let's just dump it.

Heh, MD5 checking the output of lossy codecs doesn't help you much. You
could do RMS / maxdiff checking instead (see "ISO MPEG compliance" on
http://mpg123.org); but then, still, since mpg123 supports gapless
playback, you get a different audio frame count from it than from
mp3lib. Brings be back to the point on how easily I could add options
to ad_mpg123, so that the user can choose gapless decoding or not,
volume adjustment ... and: output format (float, 24bit)!


Alrighty then,

Thomas.

* In case of a mpg123 included in MPlayer source, you need to pull the
  whole deal, e.g. svn://scm.orgis.org/mpg123/trunk; then autoreconf
  and ./configure --disable-shared in there (you want a static lib,
  right?). You can then build just the library by
  cd src/libmpg123 && make; thanks to friendly libtool, you have to dig
  the library out of src/libmpg123/.libs/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20120314/e7f7c0b4/attachment.asc>