[MPlayer-dev-eng] [PATCH]Fix FFmpeg warning

Diego Biurrun diego at biurrun.de
Fri Mar 9 21:58:14 CET 2012


On Fri, Mar 09, 2012 at 08:40:33PM +0000, Carl Eugen Hoyos wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
> 
> > > -static struct vf_priv_s {
> > > +struct vf_priv_s {
> > >          unsigned char *buf;
> > >          int brightness;
> > >          int contrast;
> > > -} const vf_priv_dflt = {
> > > +} static const vf_priv_dflt = {
> 
> > This looks wrong.
> 
> Please elaborate.

gcc can complain about static not being the first keyword in declarations
in -Wextra mode.  So I wonder what the warning you are trying to fix here
is in the first place.  Just splitting the struct and the variable
declaration could be simpler in any case.

Diego


More information about the MPlayer-dev-eng mailing list