[MPlayer-dev-eng] [PATCH] vf_pp: free private structure.
Reimar Döffinger
Reimar.Doeffinger at gmx.de
Sat Mar 3 14:38:56 CET 2012
On Sat, Mar 03, 2012 at 01:43:02PM +0100, Nicolas George wrote:
> ---
> libmpcodecs/vf_pp.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/libmpcodecs/vf_pp.c b/libmpcodecs/vf_pp.c
> index 1a5aa47..a26b280 100644
> --- a/libmpcodecs/vf_pp.c
> +++ b/libmpcodecs/vf_pp.c
> @@ -80,6 +80,7 @@ static void uninit(struct vf_instance *vf){
> pp_free_mode(vf->priv->ppMode[i]);
> }
> if(vf->priv->context) pp_free_context(vf->priv->context);
> + free(vf->priv);
> }
>
> static int query_format(struct vf_instance *vf, unsigned int fmt){
Ok, even though in principle I think it is a misdesign:
priv isn't allocated in the filter so it shouldn't be freed in it.
Changing that would be a largish change though.
More information about the MPlayer-dev-eng
mailing list