[MPlayer-dev-eng] [PATCH] VDA support for mplayer

[Carl Eugen Hoyos]

Xunzhen Quan <quanxunzhen <at> gmail.com> writes:

> > > Attachment (h264_vda_ffmpeg.diff): application/octet-stream, 9 KiB
> >
> > Given that the MPlayer-part of the patch is trivial,
> > please send the patch to ffmpeg-devel, consider fixing one issue:
> >
> 
> Should these two patches both be sent to ffmpeg-devel?

No, only the FFmpeg-relevant patch should be sent to 
ffmpeg-devel, as said the MPlayer patch is trivial and 
will be applied as soon as your FFmpeg patch is in git.

> > > -typedef struct {
> > > +typedef struct _vda_frame {
> >
> > Why is this needed?
> > Names starting with underlines are not allowed (they are
> > reserved), please choose another name.
> 
> Remove the leading underscore seems ok, I'll fix that.
> 
> I do that just because there is a pointer in the struct refer to itself,
> and it may lead to some compiler warning if no name there.

Consider choosing another name (that does not start with an 
underscore).

Carl Eugen